Introduce the wasmtime::EqRef type
#9285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `wasmtime::EqRef` type, which corresponds to Wasm's `(ref eq)` type, and statically represents Wasm references that can be tested for equality.
alexcrichton
approved these changes
Sep 19, 2024
crates/wasmtime/src/runtime/func.rs
Outdated
| @@ -1445,7 +1452,8 @@ impl Func { | |||
| /// | `(ref nofunc)` | `NoFunc` | | |||
| /// | `v128` | `V128` on `x86-64` and `aarch64` only | | |||
There was a problem hiding this comment.
While you're here mind removing this clause about aarch64/x86_64? (it's available on all platforms now)
There was a problem hiding this comment.
Ah I had no other comments so gonna go ahead and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
wasmtime::EqReftype, which corresponds to Wasm's(ref eq)type, and statically represents Wasm references that can be tested for equality. This is primarily for use withFunc::typed-style APIs.